Discussion :

[printf]

Bonjour,

Je devais faire un Bargraph basique sous LabWindows CVI (sans trop d'explications données).
D'après ce que j'ai compris j'ai fais un truc qui me donne ça:


J'ai donc fait un switch sur l'état de 'BUTTON1' (le potentiomètre); et en fonction de cet état je décris l'état de chaque LED (0 ou 1).... seulement ça me parait un peu barbare comme méthode.

Ma question est donc: Est-ce qu'il y a moyen de simplifier tout ça... ?

Voici le code de la partie en question:

Code :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
int CVICALLBACK BUTTON1 (int panel, int control, int event,
		void *callbackData, int eventData1, int eventData2)
{   int etat_BUTTON1;
	switch (event)
	{
		case EVENT_COMMIT:
 
			break;
		case EVENT_VAL_CHANGED:
			GetCtrlVal (panel, control, &etat_BUTTON1);
			switch (etat_BUTTON1)
			{
 
				case 0 : SetCtrlVal (panel, PANEL_LED, 0); SetCtrlVal (panel, PANEL_LED_2, 0); SetCtrlVal (panel, PANEL_LED_3, 0); SetCtrlVal (panel, PANEL_LED_4, 0); SetCtrlVal (panel, PANEL_LED_5, 0); SetCtrlVal (panel, PANEL_LED_6, 0); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 1 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 0); SetCtrlVal (panel, PANEL_LED_3, 0); SetCtrlVal (panel, PANEL_LED_4, 0); SetCtrlVal (panel, PANEL_LED_5, 0); SetCtrlVal (panel, PANEL_LED_6, 0); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 2 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 0); SetCtrlVal (panel, PANEL_LED_4, 0); SetCtrlVal (panel, PANEL_LED_5, 0); SetCtrlVal (panel, PANEL_LED_6, 0); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 3 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 0); SetCtrlVal (panel, PANEL_LED_5, 0); SetCtrlVal (panel, PANEL_LED_6, 0); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 4 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 0); SetCtrlVal (panel, PANEL_LED_6, 0); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 5 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 1); SetCtrlVal (panel, PANEL_LED_6, 0); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 6 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 1); SetCtrlVal (panel, PANEL_LED_6, 1); SetCtrlVal (panel, PANEL_LED_7, 0); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 7 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 1); SetCtrlVal (panel, PANEL_LED_6, 1); SetCtrlVal (panel, PANEL_LED_7, 1); SetCtrlVal (panel, PANEL_LED_8, 0); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 8 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 1); SetCtrlVal (panel, PANEL_LED_6, 1); SetCtrlVal (panel, PANEL_LED_7, 1); SetCtrlVal (panel, PANEL_LED_8, 1); SetCtrlVal (panel, PANEL_LED_9, 0); SetCtrlVal (panel, PANEL_LED_10, 0); break; 
				case 9 : SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 1); SetCtrlVal (panel, PANEL_LED_6, 1); SetCtrlVal (panel, PANEL_LED_7, 1); SetCtrlVal (panel, PANEL_LED_8, 1); SetCtrlVal (panel, PANEL_LED_9, 1); SetCtrlVal (panel, PANEL_LED_10, 0); break;
				case 10: SetCtrlVal (panel, PANEL_LED, 1); SetCtrlVal (panel, PANEL_LED_2, 1); SetCtrlVal (panel, PANEL_LED_3, 1); SetCtrlVal (panel, PANEL_LED_4, 1); SetCtrlVal (panel, PANEL_LED_5, 1); SetCtrlVal (panel, PANEL_LED_6, 1); SetCtrlVal (panel, PANEL_LED_7, 1); SetCtrlVal (panel, PANEL_LED_8, 1); SetCtrlVal (panel, PANEL_LED_9, 1); SetCtrlVal (panel, PANEL_LED_10, 1); break;
 
			}
 
			break;
	}
	return 0;
}

Voilà

[Gruik]

Salut,

Imaginons que tes constantes soient des IDs de ressources (constantes symboliques representant un entier), tu pourrait en faire un tableau statique constant dont l'indice correspond à PANEL_LED_X, à partir de là, c'est facile de faire une fonction qui allume N leds.

Yaurait aussi une technique avec une macro qui appelle une fonction en concatenant PANEL_LED_ à un numero en paramètre de la macro. Ceci est possible avec l'operateur ## du préprocesseur. Edit : en fait non.

[Médinoc]

Je ne crois pas qu'il serait possible de faire une boucle avec une macro, donc je conseillerais plutôt la première méthode.

Code C :

Sélectionner tout - Visualiser dans une fenêtre à part

1
2
3
4
5
6
7
int PanelLedIds[] = {PANEL_LED, PANEL_LED_2, etc. };
 
int i;
for(i=1 ; i<=etat_BUTTON1 ; i++)
	SetCtrlVal (panel, PanelLedIds[i-1], 1);
for( ; i<=10 ; i++)
	SetCtrlVal (panel, PanelLedIds[i-1], 0);

[printf]

Excellent je n'y aurais pas pensé, ça marche nickel !
Merci beaucoup pour votre aide.

Prochaine étape, simulation d'un tuner radio avec sélecteur de bande AM/FM/LW.

PS: Comment fait-on pour marquer le sujet comme résolu? c'est un modérateur qui s'en charge ou bien... ^_^
PS2: C'est bon, j'ai trouvé